linux-kernel - Re: [slabinfo PATCH] Fix off-by-one after readlink() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110141252480.24783@chino.kir.corp.google.com>
Date:	Fri, 14 Oct 2011 12:53:30 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Thomas Jarosch <thomas.jarosch@...ra2net.com>
cc:	Christoph Lameter <cl@...two.org>, linux-kernel@...r.kernel.org,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [slabinfo PATCH] Fix off-by-one after readlink() call

On Fri, 14 Oct 2011, Thomas Jarosch wrote:

> The problem is the line after the readlink() call:
> 
> buffer[count] = '\0';
> 
> The common technique is to reduce the buffer size by one.
> Another fix would be to check
> 
> "
> if (count < 0 || count == sizeof(buffer))
>     fatal();
> "
> 
> Reducing the buffer size by one is easier IMHO.
> 

I think this should be used for changelog.

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/