linux-kernel - Re: [PATCH] x86: mpparse: fix mp_bus_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111017221428.GB9543@elie.hsd1.il.comcast.net>
Date:	Mon, 17 Oct 2011 17:14:28 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Dan McGrath <troubledaemon@...il.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Alexey Starikovsky <aystarik@...il.com>
Subject: Re: [PATCH] x86: mpparse: fix mp_bus_not_pci handling

Bjorn Helgaas wrote:
> On Sun, Sep 25, 2011 at 3:29 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:

>> Dan bisected a Dell PowerEdge 4200 boot regression to commit f8924e770.
>> Prior to that commit, 32-bit kernels set mp_bus_not_pci for all buses
>> except PCI.  Afterwards, we set mp_bus_not_pci only for ISA.  But ISA is
>> not the only non-PCI bus, so it's better to always set mp_bus_not_pci
>> and clear it only for PCI.
[...]
>> +++ b/arch/x86/kernel/mpparse.c
>> @@ -95,8 +95,8 @@ static void __init MP_bus_info(struct mpc_bus *m)
[...]
>> +       set_bit(m->busid, mp_bus_not_pci);
>>        if (strncmp(str, BUSTYPE_ISA, sizeof(BUSTYPE_ISA) - 1) == 0) {
>> -               set_bit(m->busid, mp_bus_not_pci);
[...]
> Ping?  I don't see this in linux-next, so I don't know if it got
> dropped or if there's something wrong with it.

For what it's worth (not much, of course):

 Reviewed-by: Jonathan Nieder <jrnieder@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/