linux-kernel - Re: [PATCH] drm: avoid switching to text console if there is no panic timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110171727300.13515@chino.kir.corp.google.com>
Date:	Mon, 17 Oct 2011 17:27:42 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Mandeep Singh Baines <msb@...omium.org>
cc:	linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
	Hugh Dickins <hughd@...omium.org>,
	Hugh Dickins <hughd@...gle.com>,
	Dave Airlie <airlied@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: avoid switching to text console if there is no
 panic timeout

On Mon, 17 Oct 2011, Mandeep Singh Baines wrote:

> From: Hugh Dickins <hughd@...omium.org>
> 
> Add a check for panic_timeout in the drm_fb_helper_panic() notifier: if
> we're going to reboot immediately, the user will not be able to see the
> messages anyway, and messing with the video mode may display artifacts,
> and certainly get into several layers of complexity (including mutexes and
> memory allocations) which we shall be much safer to avoid.
> 
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> [ Edited commit message and modified to short-circuit panic_timeout < 0
>   instead of testing panic_timeout >= 0.  -Mandeep ]
> Signed-off-by: Mandeep Singh Baines <msb@...omium.org>
> Cc: Dave Airlie <airlied@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: dri-devel@...ts.freedesktop.org

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/