linux-kernel - [PATCH] checkpatch: improve error message for p1-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1319027583-17842-1-git-send-email-w.sang@pengutronix.de>
Date:	Wed, 19 Oct 2011 14:33:03 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Jonathan Cameron <jic23@....ac.uk>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Andy Whitcroft <apw@...onical.com>
Subject: [PATCH] checkpatch: improve error message for p1-check

The old error message was not precise. State now explicitly that the
prefix exists as a file/directory. Also change the conclusion ("appears
to be") into an instruction ("make sure").

Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
Acked-by: Jonathan Cameron <jic23@....ac.uk>
Cc: Andy Whitcroft <apw@...onical.com>
---
 scripts/checkpatch.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3dfc471..4bb4f88 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1506,7 +1506,7 @@ sub process {
 			if (!$file && $tree && $p1_prefix ne '' &&
 			    -e "$root/$p1_prefix") {
 				WARN("PATCH_PREFIX",
-				     "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
+				     "patch prefix '$p1_prefix' exists as file/directory. Make sure this isn't a -p0 patch\n");
 			}
 
 			if ($realfile =~ m@...clude/asm/@) {
-- 
1.7.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/