linux-kernel - Re: [Patch] Idle balancer: cache align nohz structure to improve idle load balancing scalability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1319092986.8416.50.camel@edumazet-laptop>
Date:	Thu, 20 Oct 2011 08:43:06 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Tim Chen <tim.c.chen@...ux.intel.com>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Venki Pallipadi <venki@...gle.com>
Subject: Re: [Patch] Idle balancer: cache align nohz structure to improve
 idle load balancing scalability

Le mercredi 19 octobre 2011 à 22:57 -0700, Suresh Siddha a écrit :
> On Wed, 2011-10-19 at 21:18 -0700, Eric Dumazet wrote:
> > > +	atomic_t load_balancer ____cacheline_aligned;
> > > +	atomic_t first_pick_cpu ____cacheline_aligned;
> > > +	atomic_t second_pick_cpu ____cacheline_aligned;
> > > +	cpumask_var_t idle_cpus_mask ____cacheline_aligned;
> > >  	cpumask_var_t grp_idle_mask;
> > >  	unsigned long next_balance;     /* in jiffy units */
> > >  } nohz ____cacheline_aligned;
> > > 
> > 
> > Dont you increase cache footprint, say for an Uniprocessor machine ?
> > 
> > (CONFIG_SMP=n)
> > 
> > ____cacheline_aligned_in_smp seems more suitable in this case.
> 
> I believe this code is already under ifdef CONFIG_SMP.

Right now yes, but it might change in the future after some code
cleanup / consolidation.

This kind of things are copy/pasted, and the right semantic here is
____cacheline_aligned_in_smp . It matches the changelog better.

Note: the ____cacheline_aligned on global "nohz" structure was quite
different, and in contradiction of what this patch wants to do.

Previously, we wanted to group all fields on a single cache line.
We now know it was not a scalable strategy, thanks to Tim.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/