[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111021092249.GG9819@localhost.pp.htv.fi>
Date: Fri, 21 Oct 2011 12:22:49 +0300
From: Adrian Bunk <bunk@...sta.de>
To: Michal Marek <mmarek@...e.cz>
Cc: Ingo Molnar <mingo@...e.hu>,
Arjan van de Ven <arjan@...radead.org>,
Josh Triplett <josh@...htriplett.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org,
Frederic Weisbecker <fweisbec@...il.com>,
Sam Ravnborg <sam@...nborg.org>
Subject: Re: Please revert "debug: Make CONFIG_EXPERT select
CONFIG_DEBUG_KERNEL to unhide debug options"
On Fri, Oct 21, 2011 at 10:19:29AM +0200, Michal Marek wrote:
> On 20.10.2011 23:41, Adrian Bunk wrote:
> > Ingo, would you accept if I would go through the Kconfig files and
> > monitor future changes to Kconfig files in the kernel (or if Michal does
> > it, I don't insist that it has to be me if someone else wants to do it)?
>
> What kind of changes do you have in mind? Sorry, I haven't followed the
> whole thread.
Checking the correctness and making things more robust.
An example:
config KVM
tristate "Kernel-based Virtual Machine (KVM) support"
...
# for TASKSTATS/TASK_DELAY_ACCT:
depends on NET
...
select TASKSTATS
select TASK_DELAY_ACCT
That breaks if anyone touches the dependencies of TASKSTATS
or TASK_DELAY_ACCT.
It should be solved better, my first thought would be introducing
something like a TASK_DELAY_ACCT_AVAILABLE variable.
(I am also not sure if what KVM is doing here is the best possible
solution or if there's an in-kernel interface that should be factored
out instead - but that is a secondary discussion that might start when
you look at such cross-subsystem select's.)
> Michal
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists