linux-kernel - Re: Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EA16779.7060006@suse.cz>
Date:	Fri, 21 Oct 2011 14:37:13 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Arjan van de Ven <arjan@...radead.org>,
	Josh Triplett <josh@...htriplett.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL
 to unhide debug options"

On 21.10.2011 11:22, Adrian Bunk wrote:
> On Fri, Oct 21, 2011 at 10:19:29AM +0200, Michal Marek wrote:
>> On 20.10.2011 23:41, Adrian Bunk wrote:
>>> Ingo, would you accept if I would go through the Kconfig files and 
>>> monitor future changes to Kconfig files in the kernel (or if Michal does 
>>> it, I don't insist that it has to be me if someone else wants to do it)?
>>
>> What kind of changes do you have in mind? Sorry, I haven't followed the
>> whole thread.
> 
> Checking the correctness and making things more robust.
> 
> An example:
> 
> config KVM
>         tristate "Kernel-based Virtual Machine (KVM) support"
> 	...
>         # for TASKSTATS/TASK_DELAY_ACCT:
>         depends on NET
> 	...
>         select TASKSTATS
>         select TASK_DELAY_ACCT
> 
> That breaks if anyone touches the dependencies of TASKSTATS
> or TASK_DELAY_ACCT.
> 
> It should be solved better, my first thought would be introducing
> something like a TASK_DELAY_ACCT_AVAILABLE variable.

Right, but that's a deficiency of the kconfig solver. Catalin Marinas
has patched it to at least print a warning if a dependency of a
select-ed symbol is not set. Ideally, we should get a better solver.

Michal

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/