linux-kernel - Re: Bisected: Massive memory leak in dm-snapshot in 3.1 development introduced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111023163042.4a93936c@xenia.leun.net>
Date:	Sun, 23 Oct 2011 16:30:42 +0200
From:	Michael Leun <ml@...ton.leun.net>
To:	Alasdair G Kergon <agk@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, dm-devel@...hat.com,
	Mikulas Patocka <mpatocka@...hat.com>
Subject: Re: Bisected: Massive memory leak in dm-snapshot in 3.1 development
 introduced

On Sun, 23 Oct 2011 14:44:49 +0100
Alasdair G Kergon <agk@...hat.com> wrote:

> On Sun, Oct 23, 2011 at 12:52:06PM +0300, Linus Torvalds wrote:
> > Mikulas, Alasdair? I see the mempool_free() for the "master job",
> > what about everything else? Does the dm_kcopyd_prepare_callback()
> > perhaps need to do a
> > 
> >     job->master_job = job;
> > 
> > or similar?
> 
> If you look at the other place that performs that mempool_alloc, it's
> indeed present there.
> 
> Michael - can you test if this solves the problem?
> 
> Alasdair
> 
> --- a/drivers/md/dm-kcopyd.c
> +++ b/drivers/md/dm-kcopyd.c
> @@ -628,6 +628,7 @@ void *dm_kcopyd_prepare_callback(struct
> dm_kcopyd_client *kc, job->kc = kc;
>  	job->fn = fn;
>  	job->context = context;
> +	job->master_job = job;
>  
>  	atomic_inc(&kc->nr_jobs);
>  
> 

Yup, it indeed does.

-- 
MfG,

Michael Leun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/