linux-kernel - Re: Bisected: Massive memory leak in dm-snapshot in 3.1 development introduced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzfFpnEc+Eerdi9SfMw4o17ONfYCHksJkD1O6AS5U2DoQ@mail.gmail.com>
Date:	Sun, 23 Oct 2011 12:52:06 +0300
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Alasdair G Kergon <agk@...hat.com>
Cc:	Michael Leun <ml@...ton.leun.net>,
	LKML <linux-kernel@...r.kernel.org>, dm-devel@...hat.com,
	Mikulas Patocka <mpatocka@...hat.com>
Subject: Re: Bisected: Massive memory leak in dm-snapshot in 3.1 development introduced

Making sure that Alasdair sees this too (hopefully he picked up on it
from dm-devel, but best send things directly too)

Mikulas, Alasdair? I see the mempool_free() for the "master job", what
about everything else? Does the dm_kcopyd_prepare_callback() perhaps
need to do a

    job->master_job = job;

or similar?

                   Linus

On Sun, Oct 23, 2011 at 12:21 PM, Michael Leun <ml@...ton.leun.net> wrote:
> Hi,
>
> How to reproduce:
>
> lvcreate -L30G -n testsnap vg1 # of course substitute VG as appropriate
> dd if=/dev/zero of=/dev/vg1/testsnap bs=2M # to make things clear
> lvcreate -L15G -s /dev/vg1/test -n testsnap
> dd if=/dev/zero of=/dev/vg1/testsnap bs=2M &
> watch free
>
> I noticed roughly 1GB memory vanishing from free / -/+ buffers/cache
> per 2GB copied.
>
> Bisecting yielded a6e50b409d3f9e0833e69c3c9cca822e8fa4adbb, reverting
> that from git master cures the memory leak
>
> --
> MfG,
>
> Michael Leun
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/