linux-kernel - Re: [PATCH v2 1/6] mfd: TPS65910: Handle non-existent devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EA6E1B6.9050608@fuel7.com>
Date:	Tue, 25 Oct 2011 11:20:06 -0500
From:	Kyle Manna <kyle.manna@...l7.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH v2 1/6] mfd: TPS65910: Handle non-existent devices

On 10/25/2011 11:01 AM, Mark Brown wrote:
>> Unfortunately on this chip there aren't any identification or
>> >  constant test registers.  The only register close is the
>> >  JTAGVERNUM_REG and that's will change across silicon revisions.
> It seems like a more useful implementation would be to have the driver
> read and display this revision number during boot, this will give you
> the register readability check and also let us know the device revision
> which might be useful for diagnostics.
I reviewed the register and the lowest 4 bits are the silicon revision 
(my hw reads 0x1) and the upper four bits should always be zero.  I will 
update the patch to silently succeed as long a valid value is read, else 
print a error including that value and return -ENODEV.

Should I submit an entire updated patch series or just submit a single 
patch in reply to this?  Did you have any other comments on the rest of 
the series?

- Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/