linux-kernel - Re: [PATCHv4 4/6] input/cma3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Oct 2011 09:24:48 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	dmitry.torokhov@...il.com, sameo@...ux.intel.com,
	peter.ujfalusi@...com, jic23@....ac.uk, aghayal@...eaurora.org,
	david@...deman.nu, Shubhrajyoti@...com, saaguirre@...com,
	hemanthv@...com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support

Hello Grant

  Thanks for your comments. I am fixing the  --- problem in all the patches.

>
> Mark Brown had posted a generic indirect register read/write library
> that I believe is getting merged.  Maybe this driver should be using
> it?

It is not on linux-next, and also it cannot be used directly, in order
to read you have to do set reg= (reg << 2) | 2; And AFAIK it is not
supported by the regmap

>
> Drop the .bus line.  The core code does this bit for you.

Done

>> +module_init(cma3000_spi_init);
>> +module_exit(cma3000_spi_exit);
>
> move module_init() directly below the function it registers.

Also done, but I believe the other is more elegant :)
>
>> +
>> +MODULE_DESCRIPTION("CMA3000-D0x Accelerometer SPI Driver");
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Ricardo Ribalda <ricardo.ribalda@...il.com>");
>> --
>> 1.7.7
>>
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/