linux-kernel - Re: [PATCH v2 5/6] slub: Only IPI CPUs that have per cpu obj to flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1110272257040.14619@router.home>
Date:	Thu, 27 Oct 2011 23:06:41 -0500 (CDT)
From:	Christoph Lameter <cl@...two.org>
To:	Gilad Ben-Yossef <gilad@...yossef.com>
cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Russell King <linux@....linux.org.uk>, linux-mm@...ck.org,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>,
	Sasha Levin <levinsasha928@...il.com>
Subject: Re: [PATCH v2 5/6] slub: Only IPI CPUs that have per cpu obj to
 flush

On Sun, 23 Oct 2011, Gilad Ben-Yossef wrote:

> diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
> index f58d641..b130f61 100644
> --- a/include/linux/slub_def.h
> +++ b/include/linux/slub_def.h
> @@ -102,6 +102,9 @@ struct kmem_cache {
>  	 */
>  	int remote_node_defrag_ratio;
>  #endif
> +
> +	/* Which CPUs hold local slabs for this cache. */
> +	cpumask_var_t cpus_with_slabs;
>  	struct kmem_cache_node *node[MAX_NUMNODES];
>  };

Please do not add fields to structures for passing parameters to
functions. This just increases the complexity of the patch and extends a
structures needlessly.

> diff --git a/mm/slub.c b/mm/slub.c
> index 7c54fe8..f8cbf2d 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1948,7 +1948,18 @@ static void flush_cpu_slab(void *d)
>
>  static void flush_all(struct kmem_cache *s)
>  {
> -	on_each_cpu(flush_cpu_slab, s, 1);
> +	struct kmem_cache_cpu *c;
> +	int cpu;
> +
> +	for_each_online_cpu(cpu) {
> +		c = per_cpu_ptr(s->cpu_slab, cpu);
> +		if (c && c->page)
> +			cpumask_set_cpu(cpu, s->cpus_with_slabs);
> +		else
> +			cpumask_clear_cpu(cpu, s->cpus_with_slabs);
> +	}
> +
> +	on_each_cpu_mask(s->cpus_with_slabs, flush_cpu_slab, s, 1);
>  }


You do not need s->cpus_with_slabs to be in kmem_cache. Make it a local
variable instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/