linux-kernel - RE: [PATCH v4] dmaengine: add CSR SiRFprimaII DMAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1319774982.20054.228.camel@vkoul-udesk3>
Date:	Fri, 28 Oct 2011 09:39:42 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Barry Song <Barry.Song@....com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Jassi Brar <jaswinder.singh@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	DL-SHA-WorkGroupLinux <Workgroup.Linux@....com>,
	Rongjun Ying <Rongjun.Ying@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v4] dmaengine: add CSR SiRFprimaII DMAC driver

On Fri, 2011-10-28 at 01:49 +0000, Barry Song wrote:
> > Also, Please ensure you send patches which compile with ZERO warnings:
> > drivers/dma/sirf-dma.c: In function 'sirfsoc_dma_probe':
> > drivers/dma/sirf-dma.c:616: warning: assignment from incompatible pointer
> > type
> > drivers/dma/sirf-dma.c:617: warning: assignment from incompatible pointer
> > type
> > which comes from the fact that your prep_interleaved_dma does not have
> > last argument of flags.
> > On the second one you have not rebased to patch from Jassi which I
> > applied after converting direction stuff.
> 
> 
[pls wrap 80chars within paragraphs, i have reformatted below)
> I rebased to both yours and Jassi by my merging manually. I remember
> you have changed the last param of device_prep_dma_cyclic from
> dma_data_direction to dma_transfer_direction. After checking the tree
> interleaved_dma @ git://git.infradead.org/users/vkoul/slave-dma.git,
> it doesn't. then make another compiling warning in
> sirfsoc_dma_prep_cyclic(). so I'll still use dma_data_direction in
> sirfsoc_dma_prep_cyclic().
Yes for cyclic, I have missed to fix that. I will push the fixed version
now

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/