linux-kernel - Re: [PATCH] nfs: Fix unused variable warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1320083034.4714.24.camel@lade.trondhjem.org>
Date:	Mon, 31 Oct 2011 13:43:54 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] nfs: Fix unused variable warning.

On Mon, 2011-10-31 at 23:12 +0600, Rakib Mullick wrote: 
> On Mon, Oct 31, 2011 at 9:18 PM, Trond Myklebust
> <Trond.Myklebust@...app.com> wrote:
> > On Fri, 2011-10-28 at 16:36 +0600, Rakib Mullick wrote:
> >
> > This will still cause a warning if you compile without RPC_DEBUG (e.g.
> > if CONFIG_SYSCTL isn't defined).
> >
> I didn't get any warning with CONFIG_SYSCTL=n.
> 
> > Since there is only one user, it seems better to just open-code the
> > NFS_SERVER(data->inode) in the dprintk()...
> 
> Okay, it seems reasonable. We can simply remove 'server'. Please
> consider the following patch (also attached, might have some white
> space issue).
> 
> ---
> 
>  When CONFIG_NFS=y and CONFIG_NFS_V3_{,V4}=n we get the following warning.
> 	
> 	fs/nfs/write.c: In function ‘nfs_writeback_done’:
> 	fs/nfs/write.c:1246:21: warning: unused variable ‘server’
> 
>  Remove the variable 'server' to fix the above warning.
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
> ---
> 
> diff --git a/fs/nfs/write.c b/fs/nfs/write.c
> index 2219c88..a2e4b27 100644
> --- a/fs/nfs/write.c
> +++ b/fs/nfs/write.c
> @@ -1243,7 +1243,6 @@ void nfs_writeback_done(struct rpc_task *task,
> struct nfs_write_data *data)
>  {
>  	struct nfs_writeargs	*argp = &data->args;
>  	struct nfs_writeres	*resp = &data->res;
> -	struct nfs_server	*server = NFS_SERVER(data->inode);
>  	int status;
> 
>  	dprintk("NFS: %5u nfs_writeback_done (status %d)\n",
> @@ -1277,7 +1276,7 @@ void nfs_writeback_done(struct rpc_task *task,
> struct nfs_write_data *data)
>  		if (time_before(complain, jiffies)) {
>  			dprintk("NFS:       faulty NFS server %s:"
>  				" (committed = %d) != (stable = %d)\n",
> -				server->nfs_client->cl_hostname,
> +				data->inode->nfs_client->cl_hostname,
				 ^^^^^^^^^^^^
NFS_SERVER(data->inode)->nfs_client....

> 				resp->verf->committed, argp->stable);
>  			complain = jiffies + 300 * HZ;
>  		}

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/