lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADZ9YHgR=WHzCfJf7_T_WjHJJHzOnWZsM2bWSACwLHEcHy+h-g@mail.gmail.com>
Date:	Tue, 1 Nov 2011 00:16:40 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] nfs: Fix unused variable warning.

On Mon, Oct 31, 2011 at 11:43 PM, Trond Myklebust
<Trond.Myklebust@...app.com> wrote:
> On Mon, 2011-10-31 at 23:12 +0600, Rakib Mullick wrote:
>> On Mon, Oct 31, 2011 at 9:18 PM, Trond Myklebust
>> <Trond.Myklebust@...app.com> wrote:
>> > On Fri, 2011-10-28 at 16:36 +0600, Rakib Mullick wrote:
>> +                             data->inode->nfs_client->cl_hostname,
>                                 ^^^^^^^^^^^^
> NFS_SERVER(data->inode)->nfs_client....

Opss. Sorry, should've more careful, rather doing it quickly :(.
data->inode has nothing inside named nfs_client, but didn't even
complain. I'll resend it.

Anyway, I found the two following warning in nfs/file.c

fs/nfs/file.c: In function ‘nfs_file_release’:
fs/nfs/file.c:140:17: warning: unused variable ‘dentry’
fs/nfs/file.c: In function ‘nfs_file_read’:
fs/nfs/file.c:237:9: warning: unused variable ‘count’

I'm wanting to send one patch to cleanup all these unused variable
issues. Shall I? Or, should I send separate patches?

Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ