linux-kernel - Re: [Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EB161F1.5090003@redhat.com>
Date:	Wed, 02 Nov 2011 11:29:53 -0400
From:	Adam Jackson <ajax@...hat.com>
To:	Keith Packard <keithp@...thp.com>
CC:	intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most
 places

On 11/2/11 2:20 AM, Keith Packard wrote:

> +		if (intel_dp->link_configuration [1] & DP_LANE_COUNT_ENHANCED_FRAME_EN)
> +			intel_dp->DP |= DP_ENHANCED_FRAMING;
> +
> +		/*
> +		 * Check for DPCD version>  1.1 and enhanced framing support
> +		 */
> +		if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11 &&
> +		    (intel_dp->dpcd[DP_MAX_LANE_COUNT] & DP_ENHANCED_FRAME_CAP)) {
> +			intel_dp->link_configuration[1] |= DP_LANE_COUNT_ENHANCED_FRAME_EN;
> +			intel_dp->DP |= DP_ENHANCED_FRAMING;
> +		}

Redundant.  You've already done the link_configuration |= above in the 
common code.  You can drop the second if chunk altogether.

In related news, the corresponding section for this in TRANS_DP_CTL 
setup appears to turn on enhanced framing unconditionally.  This is 
probably not a big deal, I don't think I've ever seen a display not 
support it, but.

- ajax
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/