linux-kernel - Re: [PATCH 0/3] Change ARCH_NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201111031816.37427.vapier@gentoo.org>
Date:	Thu, 3 Nov 2011 18:16:33 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Peter De Schrijver <pdeschrijver@...dia.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Paul Mundt <lethal@...ux-sh.org>,
	Magnus Damm <magnus.damm@...il.com>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	David Brown <davidb@...eaurora.org>,
	Rabin Vincent <rabin.vincent@...ricsson.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH 0/3] Change ARCH_NR_GPIO into a Kconfig variable

On Thursday 03 November 2011 13:00:44 Peter De Schrijver wrote:
> This patchset converts ARCH_NR_GPIO to a Kconfig variable as suggested by
> Russel King. It also converts some platforms to the new model.
> 
> Peter De Schrijver (3):
>   ARM: ARCH_NR_GPIO: Make ARCH_NR_GPIO a Kconfig variable
>   ARM: mach-shmobile: Use CONFIG_ARCH_NR_GPIO
>   ARM: mach-ux500 Use CONFIG_ARCH_NR_GPIO
> 
>  arch/arm/Kconfig                           |   10 ++++++++++
>  arch/arm/include/asm/gpio.h                |    4 ++++
>  arch/arm/mach-shmobile/include/mach/gpio.h |    2 --
>  arch/arm/mach-ux500/include/mach/gpio.h    |    5 -----
>  4 files changed, 14 insertions(+), 7 deletions(-)

i'm not sure how this is an improvement.  we go from declaring the define in 
the right mach-specific subdir (arch/arm/mach-xxx/include/mach/gpio.h) to an 
arm-global file (arm/Kconfig).  i'd think the ideal would be to keep all the 
mach cruft in the mach-xxx/ subdir.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)