linux-kernel - Re: [RFC PATCH v2] Tracepoint: add exec tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EB403C0.9030503@redhat.com>
Date:	Fri, 04 Nov 2011 10:24:48 -0500
From:	David Smith <dsmith@...hat.com>
To:	Pedro Alves <pedro@...esourcery.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC PATCH v2] Tracepoint: add exec tracepoint

On 11/04/2011 07:08 AM, Pedro Alves wrote:

> On Thursday 03 November 2011 15:59:48, David Smith wrote:
>> +                               if (depth == 0) {
>> +                                       trace_sched_process_exec(current, bprm);
>>                                         ptrace_event(PTRACE_EVENT_EXEC,
>>                                                         old_pid);
>> +                               }
> 
> Won't tracepoints be interested in the old pid as well?  Or does bprm
> carry that info?  That was only recently added to the ptrace event,
> which probably postdates your original patch.


Looking back at commit bb188d7 and the reasons why 'old_pid' was added,
it seems like a good idea to go ahead and add 'old_pid' to the
tracepoint as well.

v3 coming up...

Thanks for looking at this.

-- 
David Smith
dsmith@...hat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/