linux-kernel - Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111104161855.GC28902@opensource.wolfsonmicro.com>
Date:	Fri, 4 Nov 2011 16:18:56 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Mohammed, Afzal" <afzal@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Girdwood, Liam" <lrg@...com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"Nori, Sekhar" <nsekhar@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
Subject: Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count

On Fri, Nov 04, 2011 at 04:01:04PM +0000, Mohammed, Afzal wrote:
> On Fri, Nov 04, 2011 at 20:55:59, Mark Brown wrote:

> > That doesn't really clarify things - the question is why the number of
> > voltages we can set is three times a constant called _NUM_VOLTS?

> _NUM_VOLTS is the number of voltage steps.

> I will try to come up with a better explanation or rather the
> right solution, new to regulator world as of now.

So that definitely seems wrong then - n_voltages is supposed to be the
number of voltages that can be selected so if the regulator supports
_NUM_VOLTS steps then I'd expect to see that constant used directly.
Otherwise I'd suggest that the magic number needs a #define.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/