linux-kernel - Re: [PATCH v2 RESEND] ASoC: wm9081: Use snd_soc_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111104221730.GA16978@opensource.wolfsonmicro.com>
Date:	Fri, 4 Nov 2011 22:17:31 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>, alsa-devel@...a-project.org
Subject: Re: [PATCH v2 RESEND] ASoC: wm9081: Use snd_soc_update_bits for
 read-modify-write

On Wed, Oct 19, 2011 at 11:06:27AM +0800, Axel Lin wrote:

>  			/* Normal bias enable & soft start off */
> -			reg |= WM9081_BIAS_ENA;
> -			reg &= ~WM9081_VMID_RAMP;
> -			snd_soc_write(codec, WM9081_VMID_CONTROL, reg);
> +			snd_soc_update_bits(codec, WM9081_VMID_CONTROL,
> +					    WM9081_VMID_RAMP | WM9081_BIAS_ENA |
> +					    WM9081_VMID_SEL_MASK,
> +					    WM9081_BIAS_ENA);

This looks (and sounds) wrong - the original code didn't touch
VMID_SEL_MASK for this update but the new version will clear
VMID_SEL_MASK.  Even with that fixed there still seems to be some issue
here, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/