linux-kernel - Re: [PATCH v2] staging/xgifb: Convert pci_table entries to PCI_DEVICE (if PCI_ANY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111106223915.GT4682@mwanda>
Date:	Mon, 7 Nov 2011 01:39:15 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Aaro Koskinen <aaro.koskinen@....fi>
Subject: Re: [PATCH v2] staging/xgifb: Convert pci_table entries to
 PCI_DEVICE (if PCI_ANY_ID is used)

On Sun, Nov 06, 2011 at 11:12:28PM +0100, Peter Huewe wrote:
> This patch converts pci_table entries to use the PCI_DEVICE macro,
> if .subvendor and .subdevice are set to PCI_ANY_ID,
> and thus improves readability.
> 
> v2:
> Since the driver_data field isn't used anywhere we can also drop the
> assignments for class, class_mask and driver_data.
> (found by Aaro Koskinen)
> 
> KernelVersion: Staging-20111106

Don't put that into the permanent changelog.

Sometimes we ask people what tree they wrote a patch against, but the
truth is that we don't actually care.

Q: Your patch doesn't apply.  Which tree did you do it against?
A: Blah blah blah long explanation.
Q: Oh that's very nice and lovely.  Please redo it against today's
   -next tree.

For bug fixes where it could go into either the current kernel or the
next, then it is nice to say.  Normally people want a [patch -next
v2] in the subject which will get removed by git am.  Or below the
--- dashes.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)