linux-kernel - Re: [PATCH] serial: samsung: Fix build for non-Exynos4210 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuYYwQakbLqM46gVexB4Evby-aHA11hAx4N4Nw4mdYXp_yEOQ@mail.gmail.com>
Date:	Sun, 6 Nov 2011 21:43:45 +0530
From:	Thomas Abraham <thomas.abraham@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Alan Cox <alan@...ux.intel.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: samsung: Fix build for non-Exynos4210 devices

Hi Mark,

On 4 November 2011 22:46, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> exynos4120_serial_drv_data is only defined when building with support
> for Exynos4210 so use the already provided define to ensure that we
> don't reference it when building for other SoCs.
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

I missed that one. Thanks for the fix.

The Samsung device tree patches will not be merged in v3.2 merge
window. So should this fix be merged into the uart dt support patch or
should this be a separate patch?

Thanks,
Thomas.

> ---
>  drivers/tty/serial/samsung.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index efe3756..7272eee 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1649,7 +1649,7 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_serial_driver_ids);
>  #ifdef CONFIG_OF
>  static const struct of_device_id s3c24xx_uart_dt_match[] = {
>        { .compatible = "samsung,exynos4210-uart",
> -               .data = &exynos4210_serial_drv_data },
> +               .data = EXYNOS4210_SERIAL_DRV_DATA },
>        {},
>  };
>  MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match);
> --
> 1.7.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/