linux-kernel - RE: [PATCH] serial: samsung: Fix build for non-Exynos4210 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <04ea01cc9dd3$5725b110$05711330$%kim@samsung.com>
Date:	Tue, 08 Nov 2011 14:00:31 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Thomas Abraham' <thomas.abraham@...aro.org>,
	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>
Cc:	'Alan Cox' <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] serial: samsung: Fix build for non-Exynos4210 devices

Thomas Abraham wrote:
> 
> Hi Mark,
> 
> On 4 November 2011 22:46, Mark Brown
> <broonie@...nsource.wolfsonmicro.com> wrote:
> > exynos4120_serial_drv_data is only defined when building with support
> > for Exynos4210 so use the already provided define to ensure that we
> > don't reference it when building for other SoCs.
> >
> > Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> I missed that one. Thanks for the fix.
> 
> The Samsung device tree patches will not be merged in v3.2 merge
> window. So should this fix be merged into the uart dt support patch or
> should this be a separate patch?
> 

Hi all,

Okay, I will pick this up on 'next-samung-dt' tree which will be sent to
upstream in next time.

As a note, I need to sort out the tree based on v3.2-rc1 then will apply
this.

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> > ---
> >  drivers/tty/serial/samsung.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> > index efe3756..7272eee 100644
> > --- a/drivers/tty/serial/samsung.c
> > +++ b/drivers/tty/serial/samsung.c
> > @@ -1649,7 +1649,7 @@ MODULE_DEVICE_TABLE(platform,
> s3c24xx_serial_driver_ids);
> >  #ifdef CONFIG_OF
> >  static const struct of_device_id s3c24xx_uart_dt_match[] = {
> >        { .compatible = "samsung,exynos4210-uart",
> > -               .data = &exynos4210_serial_drv_data },
> > +               .data = EXYNOS4210_SERIAL_DRV_DATA },
> >        {},
> >  };
> >  MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match);
> > --
> > 1.7.7.1
> >
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/