linux-kernel - RE: [PATCH] pinctrl: hide subsystem from the populace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF173F9A5023@HQMAIL01.nvidia.com>
Date:	Mon, 7 Nov 2011 08:23:29 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>
CC:	Linaro Dev <linaro-dev@...ts.linaro.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	David Brown <davidb@...eaurora.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: RE: [PATCH] pinctrl: hide subsystem from the populace

Linus Walleij wrote at Monday, November 07, 2011 7:15 AM:
> From: Linus Walleij <linus.walleij@...aro.org>
> 
> Machines that have embedded pin controllers need to select them
> explicitly, so why broadcast their config options to menuconfig.
> We provide a helpful submenu for those machines that do select
> it, making it possible to enable debugging for example.
...
> -menuconfig PINCTRL
> -	bool "PINCTRL Support"
> +config PINCTRL
> +	bool
>  	depends on EXPERIMENTAL
> -	help
> -	  This enables the PINCTRL subsystem for controlling pins
> -	  on chip packages, for example multiplexing pins on primarily
> -	  PGA and BGA packages for systems on chip.
> -
> -	  If unsure, say N.

This seems OK.

>  if PINCTRL
> 
> +menu "Pin controllers"
> +	depends on PINCTRL
> +
>  config PINMUX
>  	bool "Support pinmux controllers"
>  	help

But shouldn't PINMUX and PINMUX_${soc} also have their help text removed;
it seems like if a SoC selects PINCTRL, it would also select PINMUX if
appropriate, and the relevant PINMUX_${soc} too?

I assume there are also patches for arch/arm/mach-${foo}/Kconfig somewhere
to select PINCTRL when appropriate; they didn't show up in my inbox, but
I haven't checked my sub-folders yet, so perhaps they're already there.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/