linux-kernel - Re: [PATCH] ramoops: Add a device file for ramoops buffer access.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANGUGtCxkK6Ozi8xAdX3rsa+v64wv1Ek5fToaCNd8dWty0jkyw@mail.gmail.com>
Date:	Tue, 8 Nov 2011 08:58:06 +0100
From:	Marco Stornelli <marco.stornelli@...il.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Bryan Freed <bfreed@...omium.org>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, msb@...omium.org, seiji.aguchi@....com
Subject: Re: [PATCH] ramoops: Add a device file for ramoops buffer access.

2011/11/8 Kees Cook <keescook@...omium.org>:
> Hi Bryan,
>
> On Mon, Nov 07, 2011 at 04:06:00PM -0800, Bryan Freed wrote:
>> Add a /dev/ramoops device file that gives direct access to ramoops buffers.
>> This interface is cleaner than using /dev/mem to access the buffers because
>> we no longer need to lseek() or (for ARM) mmap() to an address specified in
>> the sysfs mem_address file.
>
> This looks pretty good, except that I'd also want to remove all the module
> parameters since this would bypass CONFIG_STRICT_DEVMEM (imagine a
> malicious root user loading this module to spy on RAM via the new
> interface).

First of all my ack for the Bryan's patch.
The behavior about strict /dev/mem should be depends on the
reservation type, I mean if the driver calls request_mem_region
instead of request_mem_region_exclusive. Since ramoops uses the no
exclusive version I think no problems should occurs.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/