linux-kernel - RE: [PATCH 1/3] Introducing grant table V2 stucture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <291EDFCB1E9E224A99088639C4762022B4543AB204@LONPMAILBOX01.citrite.net>
Date:	Wed, 9 Nov 2011 14:56:42 +0000
From:	Paul Durrant <Paul.Durrant@...rix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"annie.li@...cle.com" <annie.li@...cle.com>
CC:	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jeremy@...p.org" <jeremy@...p.org>,
	"kurt.hackel@...cle.com" <kurt.hackel@...cle.com>
Subject: RE: [PATCH 1/3] Introducing grant table V2 stucture

I'd be happy with 'addr' or 'opaque' or somesuch if 'raw' is distasteful.

  Paul

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@...cle.com]
> Sent: 09 November 2011 14:49
> To: Paul Durrant
> Cc: annie.li@...cle.com; xen-devel@...ts.xensource.com; linux-
> kernel@...r.kernel.org; jeremy@...p.org; kurt.hackel@...cle.com
> Subject: Re: [PATCH 1/3] Introducing grant table V2 stucture
> 
> On Wed, Nov 09, 2011 at 11:11:22AM +0000, Paul Durrant wrote:
> > Annie,
> >
> >   Comments inline below...
> >
> > > -----Original Message-----
> > [snip]
> > > -static struct grant_entry *shared;
> > > +static union {
> > > +	struct grant_entry_v1 *v1;
> > > +	void *ring_addr;
> > > +} shared;
> > > +
> >
> > 'ring_addr' seems like the wrong name here; how about 'raw'?
> 
> Or 'ring'. I asked Annie to change it from 'raw' to something else
> and the first thing that came in my mind was 'ring_addr'. But this
> does not point to a ring, so the 'ring' part is wrong.
> 
> Point here is to make it descriptive. 'raw' does not carry meaning
> of _what_ it is suppose to do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/