lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111109070452.GA25768@darkstar.nay.redhat.com>
Date:	Wed, 9 Nov 2011 15:04:52 +0800
From:	Dave Young <dyoung@...hat.com>
To:	ebiederm@...ssion.com, vgoyal@...hat.com,
	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] kdump: kill redundant code

in while loop below, hole_end > crashk_res.end is impossible:
while (hole_end <= crashk_res.end) {
	[snip]
}
Killing the check code here

Signed-off-by: Dave Young <dyoung@...hat.com>
---
 kernel/kexec.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-2.6.orig/kernel/kexec.c	2011-11-01 13:06:20.000000000 +0800
+++ linux-2.6/kernel/kexec.c	2011-11-09 14:57:17.487022644 +0800
@@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c
 
 		if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT)
 			break;
-		if (hole_end > crashk_res.end)
-			break;
 		/* See if I overlap any of the segments */
 		for (i = 0; i < image->nr_segments; i++) {
 			unsigned long mstart, mend;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ