linux-kernel - Re: [PATCH] Hexagon: Use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111110152825.GA13341@huya.qualcomm.com>
Date:	Thu, 10 Nov 2011 07:28:25 -0800
From:	David Brown <davidb@...eaurora.org>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	David Brown <davidb@...eaurora.org>,
	Richard Kuo <rkuo@...eaurora.org>,
	Arnd Bergmann <arnd@...db.de>, linux-hexagon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Hexagon: Use resource_size function

On Thu, Nov 10, 2011 at 09:39:24AM +0100, Thomas Meyer wrote:
> Am Dienstag, den 08.11.2011, 17:02 -0800 schrieb David Brown:
> > Some minor nits about the formatting of the patch.
> > 
> > On Tue, Nov 08, 2011 at 07:49:30PM +0100, Thomas Meyer wrote:
> > > From: Thomas Meyer <thomas@...3r.de>
> > 
> > Shouldn't need a From: line, since it is the same as the email you
> > sent it from.
> 
> So do I need a From: line or not?
> 
> Documentation/SubmittingPatches says:
> 
>         The "from" line must be the very first line in the message body,
>         and has the form:
>         
>                 From: Original Author <author@...mple.com>
>         
>         The "from" line specifies who will be credited as the author of the
>         patch in the permanent changelog.  If the "from" line is missing,
>         then the "From:" line from the email header will be used to determine
>         the patch author in the changelog.
> 
> MUST in the meaning of RFC2119, means it is an absolut requirment. What
> should I do?

The absolute requirement is that the from line must be the first line
in the message body.  The "If the 'from' line is missing" even
suggests that it is optional.  I agree that the wording isn't all that
great.

I don't believe it hurts anything to use it, it just looks kind of odd
to have a From line that is the same as the originating email address.

You certainly don't need it, given that a vast majority of patches
posted don't contain a from line.  Git send-email only generates one
if the author is different from the one sending the message.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/