linux-kernel - Re: [PATCH] gpio: add flags to export GPIOs when requesting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111116091027.GB2596@pengutronix.de>
Date:	Wed, 16 Nov 2011 10:10:27 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Denis Kuzmenko <linux@...onet.org.ua>
Cc:	Stephen Warren <swarren@...dia.com>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH] gpio: add flags to export GPIOs when requesting

Hi,

> >> #define GPIOF_EXPORT			(1 << 2)
> >> #define GPIOF_EXPORT_DIR_CHANGEABLE	(3 << 2)
> > 
> > Then you won't have a single flag to check if the dir is changeable.

I played with both versions you mentioned and came to like this one
better, for this reason...

> > direction; just get rid of the two _DIR_ flags. That said, Wolfram's
> > patch seems to follow the conventions already in the file.
> 
> Your truth.

...and this reason :)

> > Dong Aisheng posted patch "gpio: introduce gpio_export_array to ease
> > export for gpio arrays". Which should we pick; it doesn't seem like we
> > need both mechanisms.
> 
> I vote for GPIOF_* variant (this one) since it can deal with different
> settings for each gpio pin in array.

Huh? I really missed Aisheng's one, otherwise I would have responded to
that. I also think my version is less intrusive and I surely need the
option that some pins may change directions and others may not.

BTW I didn't CC Grant, because he is on sabbatical right now, so Stephen
you are taking care of GPIO?

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)