linux-kernel - Re: [PATCH 3/4] mmc: Logging neatening

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd9GVQkLvhy2cx7n77jMtxBNK=1xG5wZ8zx_kcihHZGkFw@mail.gmail.com>
Date:	Wed, 16 Nov 2011 11:08:27 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Manuel Lauss <manuel.lauss@...il.com>,
	Cliff Cai <cliff.cai@...log.com>,
	Nicolas Pitre <nico@...xnic.net>, Chris Ball <cjb@...top.org>,
	Sascha Sommer <saschasommer@...enet.de>,
	Alex Dubov <oakad@...oo.com>,
	Bruce Chang <brucechang@....com.tw>,
	Harald Welte <HaraldWelte@...tech.com>,
	Tony Olech <tony.olech@...ndigitalsystems.com>,
	Pierre Ossman <pierre@...man.eu>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-omap@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 3/4] mmc: Logging neatening

2011/11/16 Joe Perches <joe@...ches.com>:
> On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote:
>> 2011/11/16 Joe Perches <joe@...ches.com>:
>> > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
>> >
>> > [123K of untrimmed reply]
>> >
>> > If you wrote something, I didn't find it.
>> >
>>
>> > -       dev_info(&pdev->dev, "DW MMC controller at irq %d, "
>> > -                "%d bit host data width, "
>> > -                "%u deep fifo\n",
>> > +       dev_info(&pdev->dev,
>> > +       "DW MMC controller at irq %d, %d bit host data width, %u deep fifo\n",
>> >                 irq, width, fifo_size);
>>
>> I think that tab is needed this "DW MMC controller at irq ...." ?
>
> Argument alignment isn't always the right thing.
>
> Very long formats should not necessarily be aligned
> at the open parenthesis.  It helps to determine
> when the format string or the dmesg output line length
> is too long.
Okay~ I understand clearly.
Thanks.

> Coalesce formats.
> Align arguments.
> Add pr_fmt, remove prefixes from format strings.
> Neaten DBG uses, rearrange argument order.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
Reviewed-by: NamJae Jeon <linkinjeon@...il.com>
>
>
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/