linux-kernel - Re: [PATCH 0/2] Introduce iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQjnONaMVSN32nQQQ9KOy8_tHpi9Kc7YkQXY9+vZ0a4hFJuWA@mail.gmail.com>
Date:	Wed, 16 Nov 2011 11:00:56 +0900
From:	KyongHo Cho <pullip.cho@...sung.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Ohad Ben-Cohen <ohad@...ery.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	Avi Kivity <avi@...hat.com>,
	David Brown <davidb@...eaurora.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 0/2] Introduce iommu_commit() function

On Wed, Jun 29, 2011 at 2:51 PM, Joerg Roedel <joro@...tes.org> wrote:
> On Wed, Jun 29, 2011 at 02:02:02PM +0900, KyongHo Cho wrote:
>> Hi.
>>
>> On Fri, Jun 24, 2011 at 12:31 AM, Joerg Roedel <joerg.roedel@....com> wrote:
>> > It needs to be called whenever a some code changed a domain (either by
>> > attaching/detaching devices or by mapping/unmapping pages in
>> > the domain).
>>
>> Do you mean we can invalidate IOTLB with this iommu_commit()?
>> We need to invalidate IOTLB without updating page table for some
>> optimized solutions.
>>
>> If a device in one domain is moved to other domain, IOTLB of the
>> device must be invalidated
>> because it contains translation information of the previous domain.
>
> The classic use-case is to do a single iommu-tlb flush after a set of
> page-table updates, but flushing iotlbs after moving devices is a
> potential use-case too, so the answer is yes.
>

Hi.

In the 'next' branch of
http://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git,
I found that iommu_commit() is removed.

Why is it removed?

BTW, the comment of struct iommu_ops still contains description about commit.

Regards,

  KyongHo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/