linux-kernel - RE: [PATCH 1/1] gpio: gpio-mxs: remove the duplicated micro define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Nov 2011 03:31:34 +0000
From:	Dong Aisheng-B29396 <B29396@...escale.com>
To:	Stephen Warren <swarren@...dia.com>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"arnd@...db.de" <arnd@...db.de>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	Guo Shawn-R65073 <r65073@...escale.com>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH 1/1] gpio: gpio-mxs: remove the duplicated micro define

 -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Stephen Warren
> Sent: Wednesday, November 16, 2011 2:42 AM
> To: Dong Aisheng; linux-kernel@...r.kernel.org
> Cc: grant.likely@...retlab.ca; arnd@...db.de; s.hauer@...gutronix.de; Guo
> Shawn-R65073; kernel@...gutronix.de
> Subject: RE: [PATCH 1/1] gpio: gpio-mxs: remove the duplicated micro
> define
> 
> Dong Aisheng wrote at Tuesday, November 15, 2011 2:55 AM:
> ...
> > diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> ...
> > -#define MXS_SET		0x4
> > -#define MXS_CLR		0x8
> 
> If the long-term direction on MXS is to move to gpiolib, won't
It looks gpio-mxs driver is already using gpiolib.

> MX_SET_ADDR etc. and the inline functions that use it eventually be
> removed from mach-mxs/include/mach/mxs.h hence requiring the #define be
> moved back into the GPIO driver?
> 
Yes, i agree with you.
Eventually we will remove using <mach/mxs.h>.
Thanks for the comments.

Regards
Dong Aisheng


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/