linux-kernel - Re: [PATCH] ocfs2: send correct UUID to cleancache initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111117095019.GE7319@noexit.corp.google.com>
Date:	Thu, 17 Nov 2011 01:50:21 -0800
From:	Joel Becker <jlbec@...lplan.org>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org,
	Steven Whitehouse <swhiteho@...hat.com>,
	Sunil Mushran <sunil.mushran@...cle.com>
Subject: Re: [PATCH] ocfs2: send correct UUID to cleancache initialization

On Mon, Oct 17, 2011 at 04:47:17PM -0700, Dan Magenheimer wrote:
> ocfs2: Fix cleancache initialization call to correctly pass uuid
> 
> As reported by Steven Whitehouse in https://lkml.org/lkml/2011/5/27/221 
> the ocfs2 volume UUID is incorrectly passed to cleancache.
> As a result, shared-ephemeral tmem pools will not actually
> be created; instead they will be private (unshared) which
> misses out on a major benefit of tmem.
> 
> Reported-by: Steven Whitehouse <swhiteho@...hat.com>
> Signed-off-by: Dan Magenheimer <dan.magenheimer@...cle.com>

	This patch is now in the 'fixes' branch of ocfs2.git.

Joel

> 
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -2374,7 +2374,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
>  		mlog_errno(status);
>  		goto bail;
>  	}
> -	cleancache_init_shared_fs((char *)&uuid_net_key, sb);
> +	cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb);
>  
>  bail:
>  	return status;

-- 

"Well-timed silence hath more eloquence than speech."  
         - Martin Fraquhar Tupper

			http://www.jlbec.org/
			jlbec@...lplan.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/