linux-kernel - Re: [PATCH] pipe: Fail cleanly when root tries F_SETPIPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLG7Q-DEAOXo0SpsBDFRZzFRkRdA4xnP48Khu4QdCrdrWA@mail.gmail.com>
Date:	Fri, 18 Nov 2011 23:04:08 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Sasha Levin <levinsasha928@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] pipe: Fail cleanly when root tries F_SETPIPE_SZ with big size

On Fri, Nov 18, 2011 at 10:04:34PM +0200, Sasha Levin wrote:
>> +     if (nr_pages * sizeof(struct pipe_buffer) > KMALLOC_MAX_SIZE)
>> +             return -ENOMEM;

On Fri, Nov 18, 2011 at 10:25 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> nr_pages is unsigned long, sizeof is greater than 1, KMALLOC_MAX_SIZE is
> unsigned long...  So write that check as KMALLOC_MAX_SIZE / sizeof > nr_pages

We could just use __GFP_NOWARN here and let kcalloc() deal with the
overflow case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/