linux-kernel - Re: ipv4 udplite broken in >=linux-3.0 ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABPbr_kB3mRZWoVcRVN3rmqtNmQqXq-G6P9fwE=3GDN9B_OGVw@mail.gmail.com>
Date:	Sat, 19 Nov 2011 15:08:35 +0800
From:	Jinxin Zheng <jinxinzheng@...il.com>
To:	Gerrit Renker <gerrit@....abdn.ac.uk>,
	Hagen Paul Pfeifer <hagen@...u.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: ipv4 udplite broken in >=linux-3.0 ?

On Sat, Nov 19, 2011 at 7:27 AM, Gerrit Renker <gerrit@....abdn.ac.uk> wrote:
> Jinxin, -
> | On Fri, Nov 18, 2011 at 8:04 PM, Hagen Paul Pfeifer <hagen@...u.net> wrote:
> | > * Jinxin Zheng | 2011-11-18 12:09:25 [+0800]:
> | >
> | >>I don't know how to debug udplite. Can any one of you give me a tip on
> | >>how to get more debug info, then I can do further test and provide
> | >>with it?
> | >
> | > net-next works for me:
> That is very likely the point. Between 2.6.39 and 3.0 UDP-Lite checksum coverage was
> broken and got only recently fixed. The correct kernel version should have the
> commit shown below. Alternatively, you can check include/net/udplite.h, which
> should mention "Slow-path" and "Fast-Path" computation. UDP-Litev6 still uses the
> slow path, that is why it is not affected.
>
>
> commit f36c23bb9f822904dacf83a329518d0a5fde7968
> Author: Gerrit Renker <gerrit@....abdn.ac.uk>
> Date:   Mon Oct 17 19:07:30 2011 -0400
>
>    udplite: fast-path computation of checksum coverage
>
>    Commit 903ab86d195cca295379699299c5fc10beba31c7 of 1 March this year ("udp: Add
>    lockless transmit path") introduced a new fast TX path that broke the checksum
>    coverage computation of UDP-lite, which so far depended on up->len (only set
>    if the socket is locked and 0 in the fast path).
>
>    Fixed by providing both fast- and slow-path computation of checksum coverage.
>    The latter can be removed when UDP(-lite)v6 also uses a lockless transmit path.
>
>

Thanks, Gerrit. Upgrading to the upstream linux-3.2-rc2 fixed the problem :)

-- 
Zheng Jinxin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/