linux-kernel - Re: [PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111119071915.GJ29436@mwanda>
Date:	Sat, 19 Nov 2011 10:19:15 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Ken O'Brien" <kernel@...obrien.org>
Cc:	gregkh@...e.de, lucas.demarchi@...fusion.mobi,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning.

On Sat, Nov 19, 2011 at 02:19:54AM +0000, Ken O'Brien wrote:
> Removed all checkpatch errors.
> 
> Checkpatch status before: total: 131 errors, 200 warnings, 648 lines checked
> Checkpatch status after:  total: 0 errors, 194 warnings, 620 lines checked
> 

I don't have strong opinions personally, but I think the prefered way
is to do this for one class of errors at a time.  It makes the patch
smaller and easier to review.  Then send the series of patches.

> +typedef union _U_IP_ADDRESS {
> +  struct {
> +		ULONG				ulIpv4Addr[MAX_IP_RANGE_LENGTH];/*Source Ip Address Range */
     ^    ^                  ^                                                  ^ ^
     tab tab            one space only here                                 spaces after the ';' and '*'.
The whitespace on the line above isn't right.

> +      /*
> +      * bit 1: 1 Idlemode enable;
> +      * bit 2: 1 Sleepmode Enable
> +      */

The asterisks should all line up here.

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)