linux-kernel - Re: [PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 26 Nov 2011 17:13:01 -0800
From:	Greg KH <greg@...ah.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ken O'Brien <kernel@...obrien.org>, lucas.demarchi@...fusion.mobi,
	devel@...verdev.osuosl.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: bcm: Adapter.h Checkpatch cleaning.

On Sat, Nov 19, 2011 at 10:19:15AM +0300, Dan Carpenter wrote:
> On Sat, Nov 19, 2011 at 02:19:54AM +0000, Ken O'Brien wrote:
> > Removed all checkpatch errors.
> > 
> > Checkpatch status before: total: 131 errors, 200 warnings, 648 lines checked
> > Checkpatch status after:  total: 0 errors, 194 warnings, 620 lines checked
> > 
> 
> I don't have strong opinions personally, but I think the prefered way
> is to do this for one class of errors at a time.  It makes the patch
> smaller and easier to review.  Then send the series of patches.

Yes, that is my prefered way as well.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/