linux-kernel - Re: [PATCH 5/5] Drivers: video: riva: riva

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Nov 2011 01:50:33 +0000
From:	Florian Tobias Schandinat <FlorianSchandinat@....de>
To:	Zac Storer <zac.3.14159@...il.com>
CC:	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Drivers: video: riva: riva_hw: fixed a brace coding
 style issue

On 11/18/2011 04:45 AM, Zac Storer wrote:
> Fixed a brace coding style issue.

*sigh* You are fixing coding style, but I still get lots of warnings for the
single line you are changing. IF you are fixing coding style, at least do it
right. Or do you really expect me to be happy if you send me 3 patches that all
touch the same line?
Really, if you want to fix it, at least fix it in a way that checkpatch.pl does
no longer complain about your patch, at least regarding coding style issues. And
for such patches I think a per file patch or similar would be appropriate.


Regards,

Florian Tobias Schandinat

> 
> Signed-off-by: Zac Storer <zac.3.14159@...il.com>
> ---
>  drivers/video/riva/riva_hw.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
> index 78fdbf5..c4b8a6f 100644
> --- a/drivers/video/riva/riva_hw.c
> +++ b/drivers/video/riva/riva_hw.c
> @@ -994,7 +994,7 @@ static void nv10CalcArbitration
>                clwm = clwm_mt;
>    */
>            /* Finally, a heuristic check when width == 64 bits */
> -          if(width == 1){
> +          if(width == 1) {
>                nvclk_fill = nvclk_freq * 8;
>                if(crtc_drain_rate * 100 >= nvclk_fill * 102)
>                        clwm = 0xfff; /*Large number to fail */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/