linux-kernel - Re: [patch] mpi/mpi-mpow: NULL dereference on allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALLzPKYPp6-ov5HjY9yP1iO3MWBtysVeai+CudRS7R+DVZXgEw@mail.gmail.com>
Date:	Mon, 21 Nov 2011 17:18:45 +0200
From:	"Kasatkin, Dmitry" <dmitry.kasatkin@...el.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	James Morris <jmorris@...ei.org>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] mpi/mpi-mpow: NULL dereference on allocation failure

On Mon, Nov 21, 2011 at 4:50 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> We can't call mpi_free() on the elements if the first kzalloc() fails.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@...el.com>

>
> diff --git a/lib/mpi/mpi-mpow.c b/lib/mpi/mpi-mpow.c
> index 4cc7593..7328d0d 100644
> --- a/lib/mpi/mpi-mpow.c
> +++ b/lib/mpi/mpi-mpow.c
> @@ -73,7 +73,7 @@ int mpi_mulpowm(MPI res, MPI *basearray, MPI *exparray, MPI m)
>
>        G = kzalloc((1 << k) * sizeof *G, GFP_KERNEL);
>        if (!G)
> -               goto nomem;
> +               goto err_out;
>
>        /* and calculate */
>        tmp = mpi_alloc(mpi_get_nlimbs(m) + 1);
> @@ -129,5 +129,6 @@ nomem:
>        for (i = 0; i < (1 << k); i++)
>                mpi_free(G[i]);
>        kfree(G);
> +err_out:
>        return rc;
>  }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/