linux-kernel - RE: [PATCH] pinctrl: GPIO direction support for muxing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF174F08C25F@HQMAIL01.nvidia.com>
Date:	Mon, 21 Nov 2011 14:18:45 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	Rajendra Nayak <rajendra.nayak@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Igor Grinberg <grinberg@...pulab.co.il>
Subject: RE: [PATCH] pinctrl: GPIO direction support for muxing

Linus Walleij wrote at Monday, November 21, 2011 6:00 AM:
> When requesting a single GPIO pin to be muxed in, some controllers
> will need to poke a different value into the control register
> depending on whether the pin will be used for GPIO output or GPIO
> input. So create pinmux counterparts to gpio_direction_[input|output]
> in the pinctrl framework.

Just a few very minor typos below. Otherwise,

Acked-by: Stephen Warren <swarren@...dia.com>

> diff --git a/Documentation/pinctrl.txt b/Documentation/pinctrl.txt
...
> +NOTE that platforms and individual driver shall *NOT* request GPIO pins to be
                                           ^s
> +muxed in. Instead, implement a proper gpiolib driver hand have that driver
                                                        ^ and

> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
...
> @@ -360,7 +421,7 @@ static int acquire_pins(struct pinctrl_dev *pctldev,
> 
>  	/* Try to allocate all pins in this group, one by one */
>  	for (i = 0; i < num_pins; i++) {
> -		ret = pin_request(pctldev, pins[i], func, NULL);
> +	  ret = pin_request(pctldev, pins[i], func, NULL);

Looks like a mistake.

> diff --git a/include/linux/pinctrl/pinmux.h b/include/linux/pinctrl/pinmux.h

> + * @gpio_set_direction: Since controllers may be needing different

s/be needing/need/

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/