linux-kernel - Re: [PATCH] pinctrl: GPIO direction support for muxing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuYYwQU7A1ikPoy=vNfCMtG-cQc6+t6PS=d4TCh1=KatZWADg@mail.gmail.com>
Date:	Tue, 22 Nov 2011 17:12:39 +0530
From:	Thomas Abraham <thomas.abraham@...aro.org>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org, Stephen Warren <swarren@...dia.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	Rajendra Nayak <rajendra.nayak@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Igor Grinberg <grinberg@...pulab.co.il>
Subject: Re: [PATCH] pinctrl: GPIO direction support for muxing

On 21 November 2011 18:29, Linus Walleij <linus.walleij@...ricsson.com> wrote:
> From: Linus Walleij <linus.walleij@...aro.org>
>
> When requesting a single GPIO pin to be muxed in, some controllers
> will need to poke a different value into the control register
> depending on whether the pin will be used for GPIO output or GPIO
> input. So create pinmux counterparts to gpio_direction_[input|output]
> in the pinctrl framework.

Reviewed-by: Thomas Abraham <thomas.abraham@...aro.org>

One minor comment below.

>

[...]

> diff --git a/Documentation/pinctrl.txt b/Documentation/pinctrl.txt
> index 214b961..4a946ba 100644
> --- a/Documentation/pinctrl.txt
> +++ b/Documentation/pinctrl.txt

[...]

> +Alternatively to using these special functions, it is fully allowed to use
> +named functions for each GPIO pin, the pinmux_request_gpio() will attempt to
> +obtain the function "gpioN" where "N" is the global GPIO pin number if no
> +special GPIO-handler is registered.
> +
> +The public functions to enable a certain GPIO pin

Is the above sentence incomplete?

Thanks,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/