linux-kernel - Re: [PATCH] Fixed use of rounddown_pow_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111121160635.e3f92b7f.akpm@linux-foundation.org>
Date:	Mon, 21 Nov 2011 16:06:35 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] Fixed use of rounddown_pow_of_two in ramoops

On Sat, 19 Nov 2011 14:32:15 +0100
Marco Stornelli <marco.stornelli@...il.com> wrote:

> From: Marco Stornelli <marco.stornelli@...il.com>
> 
> The return value of rounddown_pow_of_two wasn't evaluated, so the
> operation was a no-op.
> 
> Signed-off-by: Marco Stornelli <marco.stornelli@...il.com>
> ---
>  drivers/char/ramoops.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ramoops.c b/drivers/char/ramoops.c
> index 7c7f42a1f8..9658116 100644
> --- a/drivers/char/ramoops.c
> +++ b/drivers/char/ramoops.c
> @@ -126,8 +126,8 @@ static int __init ramoops_probe(struct platform_device *pdev)
>                 goto fail3;
>         }
> 
> -       rounddown_pow_of_two(pdata->mem_size);
> -       rounddown_pow_of_two(pdata->record_size);
> +       pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
> +       pdata->record_size = rounddown_pow_of_two(pdata->record_size);
> 
>         /* Check for the minimum memory size */
>         if (pdata->mem_size < MIN_MEM_SIZE &&

waah.

Reported-by: Andrew Morton <akpm@...ux-foundation.org>

There goes my chance to get my name in the kernel tree :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/