linux-kernel - Re: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201111221611.19190.arnd@arndb.de>
Date:	Tue, 22 Nov 2011 16:11:19 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	michael.hennerich@...log.com
Cc:	greg@...ah.com, device-drivers-devel@...ckfin.uclinux.org,
	drivers@...log.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching

On Friday 18 November 2011, michael.hennerich@...log.com wrote:
> From: Michael Hennerich <michael.hennerich@...log.com>
> 
> Passing device name via platform data, is a leftover from times where
> SPI module device table matching was not existent.
> 
> * Add id_table and remove old mechanism.
> (To my knowledge no intree boards affected)
> * Miscellaneous other cleanup.

The patch looks good to me, but please don't do "miscelaneous other cleanup"
in the same patch. I think doing cleanups while you change a driver is
a good idea, just do the extra step to split those out into a cleanup
patch and describe what you do, just like you have split out the bug fix.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/