linux-kernel - RE: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <544AC56F16B56944AEC3BD4E3D5917714872FF3A29@LIMKCMBX1.ad.analog.com>
Date:	Tue, 22 Nov 2011 17:03:10 +0000
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	"greg@...ah.com" <greg@...ah.com>,
	"device-drivers-devel@...ckfin.uclinux.org" 
	<device-drivers-devel@...ckfin.uclinux.org>,
	Drivers <Drivers@...log.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module
 device table matching

Arnd Bergmann wrote on 2011-11-22:
> On Friday 18 November 2011, michael.hennerich@...log.com wrote:
>> From: Michael Hennerich <michael.hennerich@...log.com>
>>
>> Passing device name via platform data, is a leftover from times where
>> SPI module device table matching was not existent.
>>
>> * Add id_table and remove old mechanism.
>> (To my knowledge no intree boards affected)
>> * Miscellaneous other cleanup.
>
> The patch looks good to me, but please don't do "miscelaneous other
> cleanup" in the same patch. I think doing cleanups while you change a
> driver is a good idea, just do the extra step to split those out into a
> cleanup patch and describe what you do, just like you have split out the
> bug fix.
>
>       Arnd

Hi Arnd,

Thanks for reminding me.
Will do in future.

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/