linux-kernel - Re: [PATCH] [TRIVIAL] x86: Kconfig: drop unknown symbol 'APM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1111222257320.28728@pobox.suse.cz>
Date:	Tue, 22 Nov 2011 22:57:49 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] x86: Kconfig: drop unknown symbol
 'APM_MODULE'

On Thu, 17 Nov 2011, Paul Bolle wrote:

> There's no Kconfig symbol APM_MODULE, so the check for it will always
> fail. There's no need to append _MODULE to tristate symbols anyhow,
> because the config tools will do the right thing automagically.

I will be taking this through apm.git instead of trivial.git.

Thanks.

> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> Added in commit a6b68076fd ("x86: compile apm and voyager module only
> when selected in Kconfig"). The reason for appending _MODULE can be
> found at https://lkml.org/lkml/2008/1/3/422 .
> 
>  arch/x86/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index cb9a104..e4d218e 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1726,7 +1726,7 @@ source "drivers/sfi/Kconfig"
>  
>  config X86_APM_BOOT
>  	def_bool y
> -	depends on APM || APM_MODULE
> +	depends on APM
>  
>  menuconfig APM
>  	tristate "APM (Advanced Power Management) BIOS support"
> -- 
> 1.7.4.4
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/