linux-kernel - Re: [PATCH v2 2/2] hugetlb: Replace BUG() with BUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1111221734310.18644@chino.kir.corp.google.com>
Date:	Tue, 22 Nov 2011 17:35:04 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	David Daney <ddaney.cavm@...il.com>
cc:	ralf@...ux-mips.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	DM <dm.n9107@...il.com>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, David Daney <david.daney@...ium.com>
Subject: Re: [PATCH v2 2/2] hugetlb: Replace BUG() with BUILD_BUG() for dummy
 definitions.

On Tue, 22 Nov 2011, David Daney wrote:

> From: David Daney <david.daney@...ium.com>
> 
> The file linux/hugetlb.h has many places where dummy symbols were
> defined so that the main source code would contain fewer:
> 
>     #ifdef CONFIG_HUGETLBFS
> 
> or
> 
>     #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> 
> If there were any misuse of these symbols, the only symptom would be
> an OOPS at runtime.  Change the BUG() to BUILD_BUG() to catch
> any such abuse at compile time instead.
> 
> Signed-off-by: David Daney <david.daney@...ium.com>

Acked-by: David Rientjes <rientjes@...gle.com>

> @@ -186,7 +186,7 @@ static inline void set_file_hugepages(struct file *file)
>  #else /* !CONFIG_HUGETLBFS */
>  
>  #define is_file_hugepages(file)			0
> -#define set_file_hugepages(file)		BUG()
> +#define set_file_hugepages(file)		BUILD_BUG()
>  static inline struct file *hugetlb_file_setup(const char *name, size_t size,
>  		vm_flags_t acctflag, struct user_struct **user, int creat_flags)
>  {

Looks like this symbol can just be removed entirely, it's not referenced 
anywhere.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/