linux-kernel - Re: [PATCH 2/2] trace_event_filter: factorize filter creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Nov 2011 07:59:52 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] trace_event_filter: factorize filter creation

Hello,

On Wed, Nov 23, 2011 at 10:19:21AM -0500, Steven Rostedt wrote:
> For such a change, I would have liked to see more deletions than
> insertions. Although, if it removes duplicate code, I'm not against such
> a change.

Yeah, certainly.  If you count out the function comments, it reduces
~30 lines of code.  I was trying to add another user and with one more
user, the stats become more attractive.

> I'll look at this more when I get some more time. But just in
> case I forget about it (because I wont look at it before my turkey
> dinner tomorrow, and will most likely forget about it come next Monday),
> please feel free to ping me again next week.

Will do so.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/