linux-kernel - Re: [PATCH 5] PM: Update comments describing device power management callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201111232101.36188.rjw@sisk.pl>
Date:	Wed, 23 Nov 2011 21:01:35 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Ming Lei <tom.leiming@...il.com>
Subject: Re: [PATCH 5] PM: Update comments describing device power management callbacks

On Wednesday, November 23, 2011, Alan Stern wrote:
> On Wed, 23 Nov 2011, Rafael J. Wysocki wrote:
> 
> > On Tuesday, November 22, 2011, Alan Stern wrote:
> > > On Tue, 22 Nov 2011, Rafael J. Wysocki wrote:
> > > 
> > > > > The same data structure (dev_pm_ops) is used for both drivers and
> > > > > subsystems.  Therefore the comments should be directed toward both
> > > > > driver writers and subsystem writers.
> > > > 
> > > > I don't quite agree.  Trying to do so would turn that comment into a lengthy
> > > > document and there's no room for anything like that in the header file.
> > > 
> > > That's a good point.
> > > 
> > > > Perhaps I'll just modify the comment to say when the callbacks are executed
> > > > without specifying what the specific callbacks are supposed to do (because
> > > > that may vary from one subsystem to another and even between different
> > > > drivers belonging to the same subsystem).  If PM domains are taken into
> > > > account, it gets even more complicated.
> > > 
> > > Yes, a minimal description would be good, along with a pointer to the 
> > > Documentation/power files.
> > 
> > Well, the one below is not exactly minimal, but I think it doesn't go too
> > far at least.
> 
> Yes, I like this version better.

Great, thanks!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/