linux-kernel - Re: [PATCH] [media] V4L: atmel-isi: add code to enable/disable ISI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111128160055.GD11432@n2100.arm.linux.org.uk>
Date:	Mon, 28 Nov 2011 16:00:55 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	linux-arm-kernel@...ts.infradead.org, g.liakhovetski@....de,
	josh.wu@...el.com, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] [media] V4L: atmel-isi: add code to enable/disable
	ISI_MCK clock

On Mon, Nov 28, 2011 at 02:34:44PM +0100, Nicolas Ferre wrote:
> From: Josh Wu <josh.wu@...el.com>
> 
> This patch
> - add ISI_MCK clock enable/disable code.
> - change field name in isi_platform_data structure
> 
> Signed-off-by: Josh Wu <josh.wu@...el.com>
> [g.liakhovetski@....de: fix label names]
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
> ---
> Guennadi,
> 
> Here is the pach form Josh and yourself about the Atmel ISI driver
> modifications. I have rebased it on top of 3.2-rc3 (and tested it on
> linux-next also).
> I plan to submit the board/device related patches (2-3/3 of this series) to
> the arm-soc tree real soon. Do you whant me to include this one or can you
> schedulle an inclusion in mainline for 3.3?

While you're doing this, why not also prepare for the common clk API by
adding support for clk_prepare()/clk_unprepare() to these drivers?

We are actually now at the point where we should be saying a firm no to
any new introductions of clk_enable()/clk_disable() without there being
corresponding clk_prepare()/clk_unprepare() calls for that clk.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/