linux-kernel - Re: [trivial PATCH] omap24xxcam-dma: Fix logical test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111128160409.GF29805@valkosipuli.localdomain>
Date:	Mon, 28 Nov 2011 18:04:09 +0200
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Joe Perches <joe@...ches.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sakari Ailus <sakari.ailus@...ia.com>
Subject: Re: [trivial PATCH] omap24xxcam-dma: Fix logical test

On Sun, Nov 27, 2011 at 11:42:15AM -0800, Joe Perches wrote:
> Likely misuse of & vs &&.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks, Joe!

Acked-by: Sakari Ailus <sakari.ailus@....fi>

> ---
>  drivers/media/video/omap24xxcam-dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/omap24xxcam-dma.c b/drivers/media/video/omap24xxcam-dma.c
> index 1d54b86..3ea38a8 100644
> --- a/drivers/media/video/omap24xxcam-dma.c
> +++ b/drivers/media/video/omap24xxcam-dma.c
> @@ -506,7 +506,7 @@ int omap24xxcam_sgdma_queue(struct omap24xxcam_sgdma *sgdma,
>  	unsigned long flags;
>  	struct sgdma_state *sg_state;
>  
> -	if ((sglen < 0) || ((sglen > 0) & !sglist))
> +	if ((sglen < 0) || ((sglen > 0) && !sglist))
>  		return -EINVAL;
>  
>  	spin_lock_irqsave(&sgdma->lock, flags);
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi	jabber/XMPP/Gmail: sailus@...iisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/